Commit ccc0a187 authored Oct 03, 2024 by Sunil Khatri Committed by Alex Deucher Oct 08, 2024

drm/amdgpu: move error log from ring write to commit



Move the error message from ring write as an optimization
to avoid printing that message on every write instead
print once during commit if it exceeds write the allocated
size i.e ring->count_dw.

Also we do not want to log the error message in between a
ring write and complete the write as its mostly not harmful
as it will overwrite stale data only as GPU read from ring
is faster than CPU write to ring.

This reduces the size of amdgpu.ko module by around
600 Kb as write is very often used function and hence
the print.

Signed-off-by: Sunil Khatri <sunil.khatri@amd.com>
Suggested-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 16445e40

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -141,6 +141,9 @@ void amdgpu_ring_commit(struct amdgpu_ring *ring)
		{
		uint32_t count;

		if (ring->count_dw < 0)
		DRM_ERROR("amdgpu: writing more dwords to the ring than expected!\n");

		/* We pad to match fetch size */
		count = ring->funcs->align_mask + 1 -
		(ring->wptr & ring->funcs->align_mask);

drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -377,8 +377,6 @@ static inline void amdgpu_ring_clear_ring(struct amdgpu_ring *ring)

		static inline void amdgpu_ring_write(struct amdgpu_ring *ring, uint32_t v)
		{
		if (ring->count_dw <= 0)
		DRM_ERROR("amdgpu: writing more dwords to the ring than expected!\n");
		ring->ring[ring->wptr++ & ring->buf_mask] = v;
		ring->wptr &= ring->ptr_mask;
		ring->count_dw--;