Commit ccd9e252 authored by Bart Van Assche's avatar Bart Van Assche Committed by Jens Axboe
Browse files

blk-mq: Make blk_mq_quiesce_tagset() hold the tag list mutex less long 



Make sure that the tag_list_lock mutex is not held any longer than
necessary. This change reduces latency if e.g. blk_mq_quiesce_tagset()
is called concurrently from more than one thread. This function is used
by the NVMe core and also by the UFS driver.

Reported-by: default avatarPeter Wang <peter.wang@mediatek.com>
Cc: Chao Leng <lengchao@huawei.com>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: stable@vger.kernel.org
Fixes: 414dd48e ("blk-mq: add tagset quiesce interface")
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarKeith Busch <kbusch@kernel.org>
Link: https://lore.kernel.org/r/20241022181617.2716173-1-bvanassche@acm.org


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 904ebd25

block/blk-mq.c

+2 −1
Original line number Diff line number Diff line
@@ -283,8 +283,9 @@ void blk_mq_quiesce_tagset(struct blk_mq_tag_set *set) 
		if (!blk_queue_skip_tagset_quiesce(q))

			blk_mq_quiesce_queue_nowait(q);

	}

	blk_mq_wait_quiesce_done(set);

	mutex_unlock(&set->tag_list_lock);



	blk_mq_wait_quiesce_done(set);

}

EXPORT_SYMBOL_GPL(blk_mq_quiesce_tagset);