Commit ccf70c41 authored by Sanman Pradhan's avatar Sanman Pradhan Committed by Guenter Roeck
Browse files

hwmon: (pxe1610) Check return value of page-select write in probe 



pxe1610_probe() writes PMBUS_PAGE to select page 0 but does not check
the return value. If the write fails, subsequent register reads operate
on an indeterminate page, leading to silent misconfiguration.

Check the return value and propagate the error using dev_err_probe(),
which also handles -EPROBE_DEFER correctly without log spam.

Fixes: 344757ba ("hwmon: (pmbus) Add Infineon PXE1610 VR driver")
Signed-off-by: default avatarSanman Pradhan <psanman@juniper.net>
Link: https://lore.kernel.org/r/20260329170925.34581-4-sanman.pradhan@hpe.com


[groeck: Fix "Fixes" SHA]
Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 0e211f6a

drivers/hwmon/pmbus/pxe1610.c

+4 −1
Original line number Diff line number Diff line
@@ -104,7 +104,10 @@ static int pxe1610_probe(struct i2c_client *client) 
	 * By default this device doesn't boot to page 0, so set page 0

	 * to access all pmbus registers.

	 */

	i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);

	ret = i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);

	if (ret < 0)

		return dev_err_probe(&client->dev, ret,

				     "Failed to set page 0\n");



	/* Read Manufacturer id */

	ret = i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf);