Commit cd06b713 authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Add a quirk for handling broken LSDBS field in controller capabilities register 



'Legacy Queue & Single Doorbell Support (LSDBS)' field in the controller
capabilities register is supposed to report whether the legacy single
doorbell mode is supported in the controller or not. But some controllers
report '1' in this field which corresponds to 'LSDB not supported', but
they indeed support LSDB. So let's add a quirk to handle those controllers.

If the quirk is enabled by the controller driver, then LSDBS register field
will be ignored and legacy single doorbell mode is assumed to be enabled
always.

Tested-by: default avatarAmit Pundir <amit.pundir@linaro.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20240816-ufs-bug-fix-v3-1-e6fe0e18e2a3@linaro.org


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f03e94f2

drivers/ufs/core/ufshcd.c

+5 −1
Original line number Diff line number Diff line
@@ -2426,7 +2426,11 @@ static inline int ufshcd_hba_capabilities(struct ufs_hba *hba) 
	 * 0h: legacy single doorbell support is available

	 * 1h: indicate that legacy single doorbell support has been removed

	 */

	if (!(hba->quirks & UFSHCD_QUIRK_BROKEN_LSDBS_CAP))

		hba->lsdb_sup = !FIELD_GET(MASK_LSDB_SUPPORT, hba->capabilities);

	else

		hba->lsdb_sup = true;



	if (!hba->mcq_sup)

		return 0;

include/ufs/ufshcd.h

+8 −0
Original line number Diff line number Diff line
@@ -676,6 +676,14 @@ enum ufshcd_quirks { 
	 * the standard best practice for managing keys).

	 */

	UFSHCD_QUIRK_KEYS_IN_PRDT			= 1 << 24,



	/*

	 * This quirk indicates that the controller reports the value 1 (not

	 * supported) in the Legacy Single DoorBell Support (LSDBS) bit of the

	 * Controller Capabilities register although it supports the legacy

	 * single doorbell mode.

	 */

	UFSHCD_QUIRK_BROKEN_LSDBS_CAP			= 1 << 25,

};



enum ufshcd_caps {