Commit cd1d6094 authored by Puranjay Mohan's avatar Puranjay Mohan Committed by Alexei Starovoitov
Browse files

bpf: xfrm: drop dead NULL check in bpf_xdp_get_xfrm_state() 



As KF_TRUSTED_ARGS is now considered the default for all kfuncs, the
opts parameter in bpf_xdp_get_xfrm_state() can never be NULL. Verifier
will detect this at load time and will not allow passing NULL to this
function. This matches the documentation above the kfunc that says this
parameter (opts) Cannot be NULL.

Acked-by: default avatarEduard Zingerman <eddyz87@gmail.com>
Signed-off-by: default avatarPuranjay Mohan <puranjay@kernel.org>
Link: https://lore.kernel.org/r/20260102180038.2708325-5-puranjay@kernel.org


Signed-off-by: default avatarAlexei Starovoitov <ast@kernel.org>
parent bddaf9ad

net/xfrm/xfrm_state_bpf.c

+1 −1
Original line number Diff line number Diff line
@@ -68,7 +68,7 @@ bpf_xdp_get_xfrm_state(struct xdp_md *ctx, struct bpf_xfrm_state_opts *opts, u32 
	struct net *net = dev_net(xdp->rxq->dev);

	struct xfrm_state *x;



	if (!opts || opts__sz < sizeof(opts->error))

	if (opts__sz < sizeof(opts->error))

		return NULL;



	if (opts__sz != BPF_XFRM_STATE_OPTS_SZ) {