Commit cd26cd65 authored by Chenghai Huang's avatar Chenghai Huang Committed by Herbert Xu
Browse files

crypto: hisilicon/debugfs - fix the struct pointer incorrectly offset problem 



Offset based on (id * size) is wrong for sqc and cqc.
(*sqc/*cqc + 1) can already offset sizeof(struct(Xqc)) length.

Fixes: 15f112f9 ("crypto: hisilicon/debugfs - mask the unnecessary info from the dump")
Cc: <stable@vger.kernel.org>
Signed-off-by: default avatarChenghai Huang <huangchenghai2@huawei.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 8552cb04

drivers/crypto/hisilicon/debugfs.c

+2 −2
Original line number Diff line number Diff line
@@ -192,7 +192,7 @@ static int qm_sqc_dump(struct hisi_qm *qm, char *s, char *name) 


	down_read(&qm->qps_lock);

	if (qm->sqc) {

		memcpy(&sqc, qm->sqc + qp_id * sizeof(struct qm_sqc), sizeof(struct qm_sqc));

		memcpy(&sqc, qm->sqc + qp_id, sizeof(struct qm_sqc));

		sqc.base_h = cpu_to_le32(QM_XQC_ADDR_MASK);

		sqc.base_l = cpu_to_le32(QM_XQC_ADDR_MASK);

		dump_show(qm, &sqc, sizeof(struct qm_sqc), "SOFT SQC");
@@ -229,7 +229,7 @@ static int qm_cqc_dump(struct hisi_qm *qm, char *s, char *name) 


	down_read(&qm->qps_lock);

	if (qm->cqc) {

		memcpy(&cqc, qm->cqc + qp_id * sizeof(struct qm_cqc), sizeof(struct qm_cqc));

		memcpy(&cqc, qm->cqc + qp_id, sizeof(struct qm_cqc));

		cqc.base_h = cpu_to_le32(QM_XQC_ADDR_MASK);

		cqc.base_l = cpu_to_le32(QM_XQC_ADDR_MASK);

		dump_show(qm, &cqc, sizeof(struct qm_cqc), "SOFT CQC");