Commit cdaecac4 authored by Suraj Kandpal's avatar Suraj Kandpal
Browse files

drm/i915/scaler: Fix WA_14011503117 



This introduces and uses a variable id which is just uninitialized.
What really needs to be used is the scaler_id.

Fixes: 73309ed9 ("drm/i915/display: WA_14011503117")
Signed-off-by: default avatarSuraj Kandpal <suraj.kandpal@intel.com>
Reviewed-by: default avatarNemesa Garg <nemesa.garg@intel.com>
Link: https://lore.kernel.org/r/20250806030856.3514127-1-suraj.kandpal@intel.com
parent 73309ed9

drivers/gpu/drm/i915/display/skl_scaler.c

+3 −2
Original line number Diff line number Diff line
@@ -959,11 +959,12 @@ void adl_scaler_ecc_unmask(const struct intel_crtc_state *crtc_state) 
	struct intel_crtc *crtc = to_intel_crtc(crtc_state->uapi.crtc);

	const struct intel_crtc_scaler_state *scaler_state =

		&crtc_state->scaler_state;

	int id;



	if (!scaler_state && scaler_state->scaler_id == -1)

		return;



	intel_de_write_fw(display, SKL_PS_ECC_STAT(crtc->pipe, id), 1);

	intel_de_write_fw(display,

			  SKL_PS_ECC_STAT(crtc->pipe, scaler_state->scaler_id),

			  1);

	intel_de_write(display, XELPD_DISPLAY_ERR_FATAL_MASK, 0);

}