Commit cdbb2dc3 authored by Alexander Duyck's avatar Alexander Duyck Committed by Paolo Abeni
Browse files

fbnic: Cleanup handling of completions 



There was an issue in that if we were to shutdown we could be left with
a completion in flight as the mailbox went away. To address that I have
added an fbnic_mbx_evict_all_cmpl function that is meant to essentially
create a "broken pipe" type response so that all callers will receive an
error indicating that the connection has been broken as a result of us
shutting down the mailbox.

Fixes: 378e5cc1 ("eth: fbnic: hwmon: Add completion infrastructure for firmware requests")
Signed-off-by: default avatarAlexander Duyck <alexanderduyck@fb.com>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/174654720578.499179.380252598204530873.stgit@ahduyck-xeon-server.home.arpa


Reviewed-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 0f9a959a

drivers/net/ethernet/meta/fbnic/fbnic_fw.c

+17 −0
Original line number Diff line number Diff line
@@ -928,6 +928,20 @@ int fbnic_mbx_poll_tx_ready(struct fbnic_dev *fbd) 
	return attempts ? 0 : -ETIMEDOUT;

}



static void __fbnic_fw_evict_cmpl(struct fbnic_fw_completion *cmpl_data)

{

	cmpl_data->result = -EPIPE;

	complete(&cmpl_data->done);

}



static void fbnic_mbx_evict_all_cmpl(struct fbnic_dev *fbd)

{

	if (fbd->cmpl_data) {

		__fbnic_fw_evict_cmpl(fbd->cmpl_data);

		fbd->cmpl_data = NULL;

	}

}



void fbnic_mbx_flush_tx(struct fbnic_dev *fbd)

{

	unsigned long timeout = jiffies + 10 * HZ + 1;
@@ -945,6 +959,9 @@ void fbnic_mbx_flush_tx(struct fbnic_dev *fbd) 
	/* Read tail to determine the last tail state for the ring */

	tail = tx_mbx->tail;



	/* Flush any completions as we are no longer processing Rx */

	fbnic_mbx_evict_all_cmpl(fbd);



	spin_unlock_irq(&fbd->fw_tx_lock);



	/* Give firmware time to process packet,