Commit cdd0cde8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Greg Kroah-Hartman
Browse files

USB: typec: tps6598x: Fix a memory leak in an error handling path 



All error handling end to the error handling path, except these ones.
Go to 'release_fw' as well here, otherwise 'fw' is leaking.

Fixes: 7e7a3c81 ("USB: typec: tps6598x: Add TPS25750 support")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/23168336f18a9f6cb1a5b47130fc134dc0510d7f.1698648980.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent a6fe37f4

drivers/usb/typec/tipd/core.c

+4 −3
Original line number Diff line number Diff line
@@ -968,16 +968,17 @@ static int tps25750_start_patch_burst_mode(struct tps6598x *tps) 
	ret = of_property_match_string(np, "reg-names", "patch-address");

	if (ret < 0) {

		dev_err(tps->dev, "failed to get patch-address %d\n", ret);

		return ret;

		goto release_fw;

	}



	ret = of_property_read_u32_index(np, "reg", ret, &addr);

	if (ret)

		return ret;

		goto release_fw;



	if (addr == 0 || (addr >= 0x20 && addr <= 0x23)) {

		dev_err(tps->dev, "wrong patch address %u\n", addr);

		return -EINVAL;

		ret = -EINVAL;

		goto release_fw;

	}



	bpms_data.addr = (u8)addr;