Commit cddbff47 authored by Jiri Pirko's avatar Jiri Pirko Committed by Paolo Abeni
Browse files

devlink: send notifications only if there are listeners 



Introduce devlink_nl_notify_need() helper and using it to check at the
beginning of notification functions to avoid overhead of composing
notification messages in case nobody listens.

Signed-off-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 11280dde

net/devlink/dev.c

+4 −1
Original line number Diff line number Diff line
@@ -204,6 +204,9 @@ static void devlink_notify(struct devlink *devlink, enum devlink_command cmd) 
	WARN_ON(cmd != DEVLINK_CMD_NEW && cmd != DEVLINK_CMD_DEL);

	WARN_ON(!devl_is_registered(devlink));



	if (!devlink_nl_notify_need(devlink))

		return;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

	if (!msg)

		return;
@@ -999,7 +1002,7 @@ static void __devlink_flash_update_notify(struct devlink *devlink, 
		cmd != DEVLINK_CMD_FLASH_UPDATE_END &&

		cmd != DEVLINK_CMD_FLASH_UPDATE_STATUS);



	if (!devl_is_registered(devlink))

	if (!devl_is_registered(devlink) || !devlink_nl_notify_need(devlink))

		return;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

net/devlink/devl_internal.h

+6 −0
Original line number Diff line number Diff line
@@ -185,6 +185,12 @@ int devlink_nl_put_nested_handle(struct sk_buff *msg, struct net *net, 
				 struct devlink *devlink, int attrtype);

int devlink_nl_msg_reply_and_new(struct sk_buff **msg, struct genl_info *info);



static inline bool devlink_nl_notify_need(struct devlink *devlink)

{

	return genl_has_listeners(&devlink_nl_family, devlink_net(devlink),

				  DEVLINK_MCGRP_CONFIG);

}



/* Notify */

void devlink_notify_register(struct devlink *devlink);

void devlink_notify_unregister(struct devlink *devlink);

net/devlink/health.c

+3 −0
Original line number Diff line number Diff line
@@ -496,6 +496,9 @@ static void devlink_recover_notify(struct devlink_health_reporter *reporter, 
	WARN_ON(cmd != DEVLINK_CMD_HEALTH_REPORTER_RECOVER);

	ASSERT_DEVLINK_REGISTERED(devlink);



	if (!devlink_nl_notify_need(devlink))

		return;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

	if (!msg)

		return;

net/devlink/linecard.c

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static void devlink_linecard_notify(struct devlink_linecard *linecard, 
	WARN_ON(cmd != DEVLINK_CMD_LINECARD_NEW &&

		cmd != DEVLINK_CMD_LINECARD_DEL);



	if (!__devl_is_registered(devlink))

	if (!__devl_is_registered(devlink) || !devlink_nl_notify_need(devlink))

		return;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);

net/devlink/param.c

+1 −1
Original line number Diff line number Diff line
@@ -343,7 +343,7 @@ static void devlink_param_notify(struct devlink *devlink, 
	 * will replay the notifications if the params are added/removed

	 * outside of the lifetime of the instance.

	 */

	if (!devl_is_registered(devlink))

	if (!devl_is_registered(devlink) || !devlink_nl_notify_need(devlink))

		return;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, GFP_KERNEL);