Commit cdf5ecc3 authored by Thorsten Blum's avatar Thorsten Blum Committed by Borislav Petkov (AMD)
Browse files

EDAC/ghes: Replace deprecated strcpy() in ghes_edac_report_mem_error() 

strcpy() has been deprecated¹ because it performs no bounds checking on the
destination buffer, which can lead to buffer overflows. Use the safer
strscpy() instead.

¹ https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy



Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: default avatarQiuxu Zhuo <qiuxu.zhuo@intel.com>
Link: https://patch.msgid.link/20251118135621.101148-2-thorsten.blum@linux.dev
parent f18e71cd

drivers/edac/ghes_edac.c

+4 −3
Original line number Diff line number Diff line
@@ -15,6 +15,7 @@ 
#include "edac_module.h"

#include <ras/ras_event.h>

#include <linux/notifier.h>

#include <linux/string.h>



#define OTHER_DETAIL_LEN	400
@@ -332,7 +333,7 @@ static int ghes_edac_report_mem_error(struct notifier_block *nb, 
		p = pvt->msg;

		p += snprintf(p, sizeof(pvt->msg), "%s", cper_mem_err_type_str(etype));

	} else {

		strcpy(pvt->msg, "unknown error");

		strscpy(pvt->msg, "unknown error");

	}



	/* Error address */
@@ -357,14 +358,14 @@ static int ghes_edac_report_mem_error(struct notifier_block *nb, 
		dimm = find_dimm_by_handle(mci, mem_err->mem_dev_handle);

		if (dimm) {

			e->top_layer = dimm->idx;

			strcpy(e->label, dimm->label);

			strscpy(e->label, dimm->label);

		}

	}

	if (p > e->location)

		*(p - 1) = '\0';



	if (!*e->label)

		strcpy(e->label, "unknown memory");

		strscpy(e->label, "unknown memory");



	/* All other fields are mapped on e->other_detail */

	p = pvt->other_detail;