Commit ce28e333 authored by Buday Csaba's avatar Buday Csaba Committed by Jakub Kicinski
Browse files

net: mdio: remove redundant fwnode cleanup 



Remove redundant fwnode cleanup in of_mdiobus_register_device()
and xpcs_plat_init_dev().

mdio_device_free() eventually calls mdio_device_release(),
which already performs fwnode_handle_put(), making the manual
cleanup unnecessary.

Combine fwnode_handle_get() with device_set_node() in
of_mdiobus_register_device() for clarity.

Signed-off-by: default avatarBuday Csaba <buday.csaba@prolan.hu>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/00847693daa8f7c8ff5dfa19dd35fc712fa4e2b5.1763995734.git.buday.csaba@prolan.hu


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a11e0d46

drivers/net/mdio/of_mdio.c

+1 −4
Original line number Diff line number Diff line
@@ -63,14 +63,11 @@ static int of_mdiobus_register_device(struct mii_bus *mdio, 
	/* Associate the OF node with the device structure so it

	 * can be looked up later.

	 */

	fwnode_handle_get(fwnode);

	device_set_node(&mdiodev->dev, fwnode);

	device_set_node(&mdiodev->dev, fwnode_handle_get(fwnode));



	/* All data is now stored in the mdiodev struct; register it. */

	rc = mdio_device_register(mdiodev);

	if (rc) {

		device_set_node(&mdiodev->dev, NULL);

		fwnode_handle_put(fwnode);

		mdio_device_free(mdiodev);

		return rc;

	}

drivers/net/pcs/pcs-xpcs-plat.c

+0 −3
Original line number Diff line number Diff line
@@ -365,9 +365,6 @@ static int xpcs_plat_init_dev(struct dw_xpcs_plat *pxpcs) 
err_clean_data:

	mdiodev->dev.platform_data = NULL;



	fwnode_handle_put(dev_fwnode(&mdiodev->dev));

	device_set_node(&mdiodev->dev, NULL);



	mdio_device_free(mdiodev);



	return ret;