Commit ce4273d8 authored Nov 22, 2022 by Xiongfeng Wang Committed by Greg Kroah-Hartman Jan 20, 2023

applicom: Fix PCI device refcount leak in applicom_init()



As comment of pci_get_class() says, it returns a pci_device with its
refcount increased and decreased the refcount for the input parameter
@from if it is not NULL.

If we break the loop in applicom_init() with 'dev' not NULL, we need to
call pci_dev_put() to decrease the refcount. Add the missing
pci_dev_put() to avoid refcount leak.

Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Link: https://lore.kernel.org/r/20221122114035.24194-1-wangxiongfeng2@huawei.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent cd0ac51c

drivers/char/applicom.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -197,8 +197,10 @@ static int __init applicom_init(void)
		if (!pci_match_id(applicom_pci_tbl, dev))
		continue;

		if (pci_enable_device(dev))
		if (pci_enable_device(dev)) {
		pci_dev_put(dev);
		return -EIO;
		}

		RamIO = ioremap(pci_resource_start(dev, 0), LEN_RAM_IO);

		@@ -207,6 +209,7 @@ static int __init applicom_init(void)
		"space at 0x%llx\n",
		(unsigned long long)pci_resource_start(dev, 0));
		pci_disable_device(dev);
		pci_dev_put(dev);
		return -EIO;
		}