Commit ce4a7ae8 authored by Abdulrasaq Lawani's avatar Abdulrasaq Lawani Committed by Helge Deller
Browse files

fbdev: offb: replace of_node_put with __free(device_node) 



Replaced instance of of_node_put with __free(device_node)
to simplify code and protect against any memory leaks
due to future changes in the control flow.

Suggested-by: default avatarJulia Lawall <julia.lawall@inria.fr>
Signed-off-by: default avatarAbdulrasaq Lawani <abdulrasaqolawani@gmail.com>
Signed-off-by: default avatarHelge Deller <deller@gmx.de>
parent 6ad959b6

drivers/video/fbdev/offb.c

+1 −2
Original line number Diff line number Diff line
@@ -357,7 +357,7 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp 
			par->cmap_type = cmap_gxt2000;

	} else if (of_node_name_prefix(dp, "vga,Display-")) {

		/* Look for AVIVO initialized by SLOF */

		struct device_node *pciparent = of_get_parent(dp);

		struct device_node *pciparent __free(device_node) = of_get_parent(dp);

		const u32 *vid, *did;

		vid = of_get_property(pciparent, "vendor-id", NULL);

		did = of_get_property(pciparent, "device-id", NULL);
@@ -369,7 +369,6 @@ static void offb_init_palette_hacks(struct fb_info *info, struct device_node *dp 
			if (par->cmap_adr)

				par->cmap_type = cmap_avivo;

		}

		of_node_put(pciparent);

	} else if (dp && of_device_is_compatible(dp, "qemu,std-vga")) {

#ifdef __BIG_ENDIAN

		const __be32 io_of_addr[3] = { 0x01000000, 0x0, 0x0 };