Commit ce88e3ef authored by Caleb Sander Mateos's avatar Caleb Sander Mateos Committed by Jens Axboe
Browse files

ublk: don't access ublk_queue in ublk_daemon_register_io_buf() 



For ublk servers with many ublk queues, accessing the ublk_queue in
ublk_daemon_register_io_buf() is a frequent cache miss. Get the flags
from the ublk_device instead, which is accessed earlier in
ublk_ch_uring_cmd_local().

Signed-off-by: default avatarCaleb Sander Mateos <csander@purestorage.com>
Reviewed-by: default avatarMing Lei <ming.lei@redhat.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 692cf47e

drivers/block/ublk_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -2169,7 +2169,7 @@ ublk_daemon_register_io_buf(struct io_uring_cmd *cmd, 
		return ublk_register_io_buf(cmd, ub, ubq, io, index,

					    issue_flags);



	if (!ublk_support_zero_copy(ubq) || !ublk_rq_has_data(req))

	if (!ublk_dev_support_zero_copy(ub) || !ublk_rq_has_data(req))

		return -EINVAL;



	ret = io_buffer_register_bvec(cmd, req, ublk_io_release, index,