Commit ceab575c authored by Rob Clark's avatar Rob Clark
Browse files

drm/msm/gem: Don't queue job to sched in error cases



We shouldn't be running the job in error cases.  This also avoids having
to think too hard about where the objs get unpinned (and if necessary,
the resv takes over tracking that the obj is busy).. ie. error cases it
always happens synchronously, and normal cases it happens from scheduler
job_run() callback.

Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Patchwork: https://patchwork.freedesktop.org/patch/568331/
parent 202f98c1
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -946,6 +946,9 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
		}
	}

	if (ret)
		goto out;

	submit_attach_object_fences(submit);

	/* The scheduler owns a ref now: */