Commit ceea7868 authored by Uros Bizjak's avatar Uros Bizjak Committed by Borislav Petkov (AMD)
Browse files

x86/local: Remove trailing semicolon from _ASM_XADD in local_add_return() 



Remove the trailing semicolon from the inline assembly statement in
local_add_return().

The _ASM_XADD macro already expands to a complete instruction, making
the extra semicolon unnecessary. More importantly, the stray semicolon
causes GCC to treat the inline asm as containing multiple instructions,
which can skew its internal instruction count estimation and affect
optimization heuristics.

No functional change intended.

Signed-off-by: default avatarUros Bizjak <ubizjak@gmail.com>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://patch.msgid.link/20260308171250.7278-1-ubizjak@gmail.com
parent 09fbb775

arch/x86/include/asm/local.h

+1 −1
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ static inline bool local_add_negative(long i, local_t *l) 
static inline long local_add_return(long i, local_t *l)

{

	long __i = i;

	asm volatile(_ASM_XADD "%0, %1;"

	asm volatile(_ASM_XADD "%0, %1"

		     : "+r" (i), "+m" (l->a.counter)

		     : : "memory");

	return i + __i;