Unverified Commit cef35907 authored by Lenko Donchev's avatar Lenko Donchev Committed by Konstantin Komarov
Browse files

fs/ntfs3: use kcalloc() instead of kzalloc() 

We are trying to get rid of all multiplications from allocation
functions to prevent integer overflows[1]. Here the multiplication is
obviously safe, but using kcalloc() is more appropriate and improves
readability. This patch has no effect on runtime behavior.

Link: https://github.com/KSPP/linux/issues/162 [1]
Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments

 [2]

Signed-off-by: default avatarLenko Donchev <lenko.donchev@gmail.com>
Signed-off-by: default avatarKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
parent 0bbac3fa

fs/ntfs3/frecord.c

+1 −1
Original line number Diff line number Diff line
@@ -2636,7 +2636,7 @@ int ni_read_frame(struct ntfs_inode *ni, u64 frame_vbo, struct page **pages, 
		goto out1;

	}



	pages_disk = kzalloc(npages_disk * sizeof(struct page *), GFP_NOFS);

	pages_disk = kcalloc(npages_disk, sizeof(*pages_disk), GFP_NOFS);

	if (!pages_disk) {

		err = -ENOMEM;

		goto out2;