Commit cefa98e8 authored by Hui Zhou's avatar Hui Zhou Committed by Jakub Kicinski
Browse files

nfp: flower: add hardware offload check for post ct entry 



The nfp offload flow pay will not allocate a mask id when the out port
is openvswitch internal port. This is because these flows are used to
configure the pre_tun table and are never actually send to the firmware
as an add-flow message. When a tc rule which action contains ct and
the post ct entry's out port is openvswitch internal port, the merge
offload flow pay with the wrong mask id of 0 will be send to the
firmware. Actually, the nfp can not support hardware offload for this
situation, so return EOPNOTSUPP.

Fixes: bd0fe7f9 ("nfp: flower-ct: add zone table entry when handling pre/post_ct flows")
CC: stable@vger.kernel.org # 5.14+
Signed-off-by: default avatarHui Zhou <hui.zhou@corigine.com>
Signed-off-by: default avatarLouis Peens <louis.peens@corigine.com>
Link: https://lore.kernel.org/r/20240124151909.31603-2-louis.peens@corigine.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 53432671

drivers/net/ethernet/netronome/nfp/flower/conntrack.c

+21 −1
Original line number Diff line number Diff line
@@ -1864,10 +1864,30 @@ int nfp_fl_ct_handle_post_ct(struct nfp_flower_priv *priv, 
{

	struct flow_rule *rule = flow_cls_offload_flow_rule(flow);

	struct nfp_fl_ct_flow_entry *ct_entry;

	struct flow_action_entry *ct_goto;

	struct nfp_fl_ct_zone_entry *zt;

	struct flow_action_entry *act;

	bool wildcarded = false;

	struct flow_match_ct ct;

	struct flow_action_entry *ct_goto;

	int i;



	flow_action_for_each(i, act, &rule->action) {

		switch (act->id) {

		case FLOW_ACTION_REDIRECT:

		case FLOW_ACTION_REDIRECT_INGRESS:

		case FLOW_ACTION_MIRRED:

		case FLOW_ACTION_MIRRED_INGRESS:

			if (act->dev->rtnl_link_ops &&

			    !strcmp(act->dev->rtnl_link_ops->kind, "openvswitch")) {

				NL_SET_ERR_MSG_MOD(extack,

						   "unsupported offload: out port is openvswitch internal port");

				return -EOPNOTSUPP;

			}

			break;

		default:

			break;

		}

	}



	flow_rule_match_ct(rule, &ct);

	if (!ct.mask->ct_zone) {