Commit cf0a96de authored by Russell King (Oracle)'s avatar Russell King (Oracle) Committed by Paolo Abeni
Browse files

net: stmmac: deprecate "snps,en-tx-lpi-clockgating" property 



Whether the MII transmit clock can be stopped is primarily a property
of the PHY (there is a capability bit that should be checked first.)
Whether the MAC is capable of stopping the transmit clock is a separate
issue, but this is already handled by the core DesignWare MAC code.

Therefore, snps,en-tx-lpi-clockgating is technically incorrect, and
this commit adds a warning should a DT be encountered with the property
present.

However, we keep backwards compatibility.

Signed-off-by: default avatarRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Reviewed-by: default avatarLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Link: https://patch.msgid.link/E1tsIUK-005vGk-H7@rmk-PC.armlinux.org.uk


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent a62b7901

drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

+4 −1
Original line number Diff line number Diff line
@@ -497,8 +497,11 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) 
	plat->force_sf_dma_mode =

		of_property_read_bool(np, "snps,force_sf_dma_mode");



	if (of_property_read_bool(np, "snps,en-tx-lpi-clockgating"))

	if (of_property_read_bool(np, "snps,en-tx-lpi-clockgating")) {

		dev_warn(&pdev->dev,

			 "OF property snps,en-tx-lpi-clockgating is deprecated, please convert driver to use STMMAC_FLAG_EN_TX_LPI_CLK_PHY_CAP\n");

		plat->flags |= STMMAC_FLAG_EN_TX_LPI_CLOCKGATING;

	}



	/* Set the maxmtu to a default of JUMBO_LEN in case the

	 * parameter is not present in the device tree.