Commit cf57b5d7 authored by Wang Hai's avatar Wang Hai Committed by Jakub Kicinski
Browse files

net: ethernet: aeroflex: fix potential memory leak in greth_start_xmit_gbit() 



The greth_start_xmit_gbit() returns NETDEV_TX_OK without freeing skb
in case of skb->len being too long, add dev_kfree_skb() to fix it.

Fixes: d4c41139 ("net: Add Aeroflex Gaisler 10/100/1G Ethernet MAC driver")
Signed-off-by: default avatarWang Hai <wanghai38@huawei.com>
Reviewed-by: default avatarGerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20241012110434.49265-1-wanghai38@huawei.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a1494d53

drivers/net/ethernet/aeroflex/greth.c

+2 −1
Original line number Diff line number Diff line
@@ -484,7 +484,7 @@ greth_start_xmit_gbit(struct sk_buff *skb, struct net_device *dev) 


	if (unlikely(skb->len > MAX_FRAME_SIZE)) {

		dev->stats.tx_errors++;

		goto out;

		goto len_error;

	}



	/* Save skb pointer. */
@@ -575,6 +575,7 @@ greth_start_xmit_gbit(struct sk_buff *skb, struct net_device *dev) 
map_error:

	if (net_ratelimit())

		dev_warn(greth->dev, "Could not create TX DMA mapping\n");

len_error:

	dev_kfree_skb(skb);

out:

	return err;