Commit cf7ee25e authored by Matt Johnston's avatar Matt Johnston Committed by Paolo Abeni
Browse files

mctp i3c: handle NULL header address



daddr can be NULL if there is no neighbour table entry present,
in that case the tx packet should be dropped.

saddr will usually be set by MCTP core, but check for NULL in case a
packet is transmitted by a different protocol.

Signed-off-by: default avatarMatt Johnston <matt@codeconstruct.com.au>
Fixes: c8755b29 ("mctp i3c: MCTP I3C driver")
Link: https://patch.msgid.link/20250304-mctp-i3c-null-v1-1-4416bbd56540@codeconstruct.com.au


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent ccc2f5a4
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -507,6 +507,9 @@ static int mctp_i3c_header_create(struct sk_buff *skb, struct net_device *dev,
{
	struct mctp_i3c_internal_hdr *ihdr;

	if (!daddr || !saddr)
		return -EINVAL;

	skb_push(skb, sizeof(struct mctp_i3c_internal_hdr));
	skb_reset_mac_header(skb);
	ihdr = (void *)skb_mac_header(skb);