Commit cf82a80a authored by Alex Hung's avatar Alex Hung Committed by Alex Deucher
Browse files

drm/amd/display: Skip on writeback when it's not applicable 

[WHY]
dynamic memory safety error detector (KASAN) catches and generates error
messages "BUG: KASAN: slab-out-of-bounds" as writeback connector does not
support certain features which are not initialized.

[HOW]
Skip them when connector type is DRM_MODE_CONNECTOR_WRITEBACK.

Link: https://gitlab.freedesktop.org/drm/amd/-/issues/3199


Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Reviewed-by: default avatarRodrigo Siqueira <rodrigo.siqueira@amd.com>
Acked-by: default avatarRoman Li <roman.li@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent b3f98c00

drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

+8 −1
Original line number Diff line number Diff line
@@ -3047,6 +3047,10 @@ static int dm_resume(void *handle) 
	/* Do mst topology probing after resuming cached state*/

	drm_connector_list_iter_begin(ddev, &iter);

	drm_for_each_connector_iter(connector, &iter) {



		if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)

			continue;



		aconnector = to_amdgpu_dm_connector(connector);

		if (aconnector->dc_link->type != dc_connection_mst_branch ||

		    aconnector->mst_root)
@@ -5926,6 +5930,9 @@ get_highest_refresh_rate_mode(struct amdgpu_dm_connector *aconnector, 
		&aconnector->base.probed_modes :

		&aconnector->base.modes;



	if (aconnector->base.connector_type == DRM_MODE_CONNECTOR_WRITEBACK)

		return NULL;



	if (aconnector->freesync_vid_base.clock != 0)

		return &aconnector->freesync_vid_base;
@@ -8767,10 +8774,10 @@ static void amdgpu_dm_commit_audio(struct drm_device *dev, 
		if (!drm_atomic_crtc_needs_modeset(new_crtc_state))

			continue;



notify:

		if (connector->connector_type == DRM_MODE_CONNECTOR_WRITEBACK)

			continue;



notify:

		aconnector = to_amdgpu_dm_connector(connector);



		mutex_lock(&adev->dm.audio_lock);