Commit cf8989d2 authored by Michael Ellerman's avatar Michael Ellerman
Browse files

powerpc/powernv: Free name on error in opal_event_init() 



In opal_event_init() if request_irq() fails name is not freed, leading
to a memory leak. The code only runs at boot time, there's no way for a
user to trigger it, so there's no security impact.

Fix the leak by freeing name in the error path.

Reported-by: default avatar2639161967 <2639161967@qq.com>
Closes: https://lore.kernel.org/linuxppc-dev/87wmjp3wig.fsf@mail.lhotse


Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://patch.msgid.link/20240920093520.67997-1-mpe@ellerman.id.au
parent 8956c582

arch/powerpc/platforms/powernv/opal-irqchip.c

+1 −0
Original line number Diff line number Diff line
@@ -282,6 +282,7 @@ int __init opal_event_init(void) 
				 name, NULL);

		if (rc) {

			pr_warn("Error %d requesting OPAL irq %d\n", rc, (int)r->start);

			kfree(name);

			continue;

		}

	}