Unverified Commit cfa5f336 authored by David Howells's avatar David Howells Committed by Christian Brauner
Browse files

devpts: Fix type for uid and gid params 



Fix devpts to parse uid and gid params using the correct type so that they
get interpreted in the context of the user namespace.

Fixes: cc0876f8 ("vfs: Convert devpts to use the new mount API")
Reported-by: default avatarDebarshi Ray <dray@redhat.com>
Closes: https://github.com/containers/podman/issues/25751


Signed-off-by: default avatarGiuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/r/759134.1743596274@warthog.procyon.org.uk


cc: Eric Sandeen <sandeen@redhat.com>
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent 0af2f6be

fs/devpts/inode.c

+2 −2
Original line number Diff line number Diff line
@@ -89,12 +89,12 @@ enum { 
};



static const struct fs_parameter_spec devpts_param_specs[] = {

	fsparam_u32	("gid",		Opt_gid),

	fsparam_gid	("gid",		Opt_gid),

	fsparam_s32	("max",		Opt_max),

	fsparam_u32oct	("mode",	Opt_mode),

	fsparam_flag	("newinstance",	Opt_newinstance),

	fsparam_u32oct	("ptmxmode",	Opt_ptmxmode),

	fsparam_u32	("uid",		Opt_uid),

	fsparam_uid	("uid",		Opt_uid),

	{}

};