Commit d01240b2 authored by clingfei's avatar clingfei Committed by Linus Walleij
Browse files

pinctrl: thead1520: Fix Null pointer dereference 



pinmux_generic_get_function may return NULL, and its retval is
dereferenced without check, which will cause a NULL pointer
dereference.

Signed-off-by: default avatarclingfei <clf700383@gmail.com>
Reviewed-by: default avatarDrew Fustini <dfustini@tenstorrent.com>
Link: https://lore.kernel.org/20241003023307.2138695-1-clf700383@gmail.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 06783dc5

drivers/pinctrl/pinctrl-th1520.c

+2 −0
Original line number Diff line number Diff line
@@ -798,6 +798,8 @@ static int th1520_pinmux_set_mux(struct pinctrl_dev *pctldev, 
	struct th1520_pinctrl *thp = pinctrl_dev_get_drvdata(pctldev);

	const struct function_desc *func = pinmux_generic_get_function(pctldev, fsel);



	if (!func)

		return -EINVAL;

	return th1520_pinmux_set(thp, thp->desc.pins[gsel].number,

				 (uintptr_t)thp->desc.pins[gsel].drv_data & TH1520_PAD_MUXDATA,

				 (uintptr_t)func->data);