Commit d01ca870 authored by Harry Wentland's avatar Harry Wentland Committed by Alex Deucher
Browse files

drm/amd/display: Don't check for NULL divisor in fixpt code 

[Why]
We check for a NULL divisor but don't act on it.
This check does nothing other than throw a warning.
It does confuse static checkers though:
See https://lkml.org/lkml/2025/4/26/371



[How]
Drop the ASSERTs in both DC and SPL variants.

Fixes: 4562236b ("drm/amd/dc: Add dc display driver (v2)")
Fixes: 6efc0ab3 ("drm/amd/display: add back quality EASF and ISHARP and dc dependency changes")
Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Leo Li <sunpeng.li@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Reviewed-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent e2255687

drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c

+0 −5
Original line number Diff line number Diff line
@@ -51,8 +51,6 @@ static inline unsigned long long complete_integer_division_u64( 
{

	unsigned long long result;



	ASSERT(divisor);



	result = div64_u64_rem(dividend, divisor, remainder);



	return result;
@@ -213,9 +211,6 @@ struct fixed31_32 dc_fixpt_recip(struct fixed31_32 arg) 
	 * @note

	 * Good idea to use Newton's method

	 */



	ASSERT(arg.value);



	return dc_fixpt_from_fraction(

		dc_fixpt_one.value,

		arg.value);

drivers/gpu/drm/amd/display/dc/sspl/spl_fixpt31_32.c

+0 −4
Original line number Diff line number Diff line
@@ -29,8 +29,6 @@ static inline unsigned long long spl_complete_integer_division_u64( 
{

	unsigned long long result;



	SPL_ASSERT(divisor);



	result = spl_div64_u64_rem(dividend, divisor, remainder);



	return result;
@@ -196,8 +194,6 @@ struct spl_fixed31_32 spl_fixpt_recip(struct spl_fixed31_32 arg) 
	 * Good idea to use Newton's method

	 */



	SPL_ASSERT(arg.value);



	return spl_fixpt_from_fraction(

		spl_fixpt_one.value,

		arg.value);