Commit d0bc38d7 authored by Umang Jain's avatar Umang Jain Committed by Greg Kroah-Hartman
Browse files

staging: vc04_services: Cleanup TODO entry 

The TODO entry "Fix behvaiour of message handling" no longer
applies due to killable completions [1]. Drop the entry from TODO list.

[1] https://lore.kernel.org/all/20240918163100.870596-1-umang.jain@ideasonboard.com/



Signed-off-by: default avatarUmang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20241107194806.90408-2-umang.jain@ideasonboard.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 61ba8626

drivers/staging/vc04_services/interface/TODO

+0 −9
Original line number Diff line number Diff line
@@ -26,12 +26,3 @@ kthreads, userspace, limitations) could be very helpful for reviewers. 
The code follows the 80 characters limitation yet tends to go 3 or 4 levels of

indentation deep making it very unpleasant to read. This is specially relevant

in the character driver ioctl code and in the core thread functions.
 


* Fix behavior of message handling



The polling behavior of vchiq_bulk_transmit(), vchiq_bulk_receive() and

vchiq_queue_kernel_message() looks broken. A possible signal should be

propagated back to user space to let the calling task handle it before

retrying. Hopefully these msleep(1) shouldn't be necessary anymore.



https://lore.kernel.org/linux-staging/CAK8P3a3HGm1cPo4sW9fOY4E8AN8yAq3tevXxU5m8bmtmsU8WKw@mail.gmail.com/