Commit d17074ac authored Mar 30, 2021 by Lee Jones Committed by Tyler Hicks Apr 19, 2021

ecryptfs: inode: Help out nearly-there header and demote non-conformant ones

Fixes the following W=1 kernel build warning(s):

fs/ecryptfs/inode.c:27: warning: Function parameter or member 'dentry' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: Function parameter or member 'lower_dentry' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: Function parameter or member 'lower_dir' not described in 'lock_parent'
fs/ecryptfs/inode.c:27: warning: expecting prototype for eCryptfs(). Prototype was for lock_parent() instead
fs/ecryptfs/inode.c:211: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_initialize_file'
fs/ecryptfs/inode.c:211: warning: Function parameter or member 'ecryptfs_inode' not described in 'ecryptfs_initialize_file'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'mnt_userns' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'directory_inode' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'ecryptfs_dentry' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Function parameter or member 'excl' not described in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Excess function parameter 'dir' description in 'ecryptfs_create'
fs/ecryptfs/inode.c:258: warning: Excess function parameter 'dentry' description in 'ecryptfs_create'
fs/ecryptfs/inode.c:320: warning: Function parameter or member 'dentry' not described in 'ecryptfs_lookup_interpose'
fs/ecryptfs/inode.c:320: warning: Function parameter or member 'lower_dentry' not described in 'ecryptfs_lookup_interpose'
fs/ecryptfs/inode.c:887: warning: Function parameter or member 'mnt_userns' not described in 'ecryptfs_setattr'

Cc: Tyler Hicks <code@tyhicks.com>
Cc: "Michael A. Halcrow" <mahalcro@us.ibm.com>
Cc: "Michael C. Thompsion" <mcthomps@us.ibm.com>
Cc: ecryptfs@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Tyler Hicks <code@tyhicks.com>

parent 688a9f7c

fs/ecryptfs/inode.c

+5 −6

Original line number	Diff line number	Diff line
		// SPDX-License-Identifier: GPL-2.0-or-later
		/**
		/*
		* eCryptfs: Linux filesystem encryption layer
		*
		* Copyright (C) 1997-2004 Erez Zadok
		@@ -203,7 +203,7 @@ ecryptfs_do_create(struct inode *directory_inode,
		return inode;
		}

		/**
		/*
		* ecryptfs_initialize_file
		*
		* Cause the file to be changed from a basic empty file to an ecryptfs
		@@ -246,10 +246,8 @@ int ecryptfs_initialize_file(struct dentry *ecryptfs_dentry,
		return rc;
		}

		/**
		/*
		* ecryptfs_create
		* @dir: The inode of the directory in which to create the file.
		* @dentry: The eCryptfs dentry
		* @mode: The mode of the new file.
		*
		* Creates a new file.
		@@ -317,7 +315,7 @@ static int ecryptfs_i_size_read(struct dentry dentry, struct inode inode)
		return 0;
		}

		/**
		/*
		* ecryptfs_lookup_interpose - Dentry interposition for a lookup
		*/
		static struct dentry ecryptfs_lookup_interpose(struct dentry dentry,
		@@ -887,6 +885,7 @@ ecryptfs_permission(struct user_namespace mnt_userns, struct inode inode,

		/**
		* ecryptfs_setattr
		* @mnt_userns: user namespace of the target mount
		* @dentry: dentry handle to the inode to modify
		* @ia: Structure with flags of what to change and values
		*