Commit d19ecd85 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda/realtek: Clean up with snd_hda_codec_set_gpio() 



Use a new helper function to clean up the code.

Along with it, make alc_write_gpio() static as well, which is used
only locally in realtek.c.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20260409093826.1317626-4-tiwai@suse.de
parent cd8fd5a0

sound/hda/codecs/realtek/realtek.c

+4 −9
Original line number Diff line number Diff line
@@ -123,22 +123,17 @@ void alc_update_gpio_data(struct hda_codec *codec, unsigned int mask, 
}

EXPORT_SYMBOL_NS_GPL(alc_update_gpio_data, "SND_HDA_CODEC_REALTEK");



void alc_write_gpio(struct hda_codec *codec)

static void alc_write_gpio(struct hda_codec *codec)

{

	struct alc_spec *spec = codec->spec;



	if (!spec->gpio_mask)

		return;



	snd_hda_codec_write(codec, codec->core.afg, 0,

			    AC_VERB_SET_GPIO_MASK, spec->gpio_mask);

	snd_hda_codec_write(codec, codec->core.afg, 0,

			    AC_VERB_SET_GPIO_DIRECTION, spec->gpio_dir);

	if (spec->gpio_write_delay)

		msleep(1);

	alc_write_gpio_data(codec);

	snd_hda_codec_set_gpio(codec, spec->gpio_mask, spec->gpio_dir,

			       spec->gpio_data,

			       spec->gpio_write_delay ? 1 : 0);

}

EXPORT_SYMBOL_NS_GPL(alc_write_gpio, "SND_HDA_CODEC_REALTEK");



void alc_fixup_gpio(struct hda_codec *codec, int action, unsigned int mask)

{

sound/hda/codecs/realtek/realtek.h

+0 −1
Original line number Diff line number Diff line
@@ -171,7 +171,6 @@ void alc_setup_gpio(struct hda_codec *codec, unsigned int mask); 
void alc_write_gpio_data(struct hda_codec *codec);

void alc_update_gpio_data(struct hda_codec *codec, unsigned int mask,

			  bool on);

void alc_write_gpio(struct hda_codec *codec);



/* common GPIO fixups */

void alc_fixup_gpio(struct hda_codec *codec, int action, unsigned int mask);