Unverified Commit d1a196e0 authored by Thorsten Blum's avatar Thorsten Blum Committed by Ilpo Järvinen
Browse files

platform/x86: dell-wmi-sysman: Don't hex dump plaintext password data 



set_new_password() hex dumps the entire buffer, which contains plaintext
password data, including current and new passwords. Remove the hex dump
to avoid leaking credentials.

Fixes: e8a60aa7 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarThorsten Blum <thorsten.blum@linux.dev>
Link: https://patch.msgid.link/20260303113050.58127-2-thorsten.blum@linux.dev


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 3350c2b3

drivers/platform/x86/dell/dell-wmi-sysman/passwordattr-interface.c

+0 −1
Original line number Diff line number Diff line
@@ -93,7 +93,6 @@ int set_new_password(const char *password_type, const char *new) 
	if (ret < 0)

		goto out;



	print_hex_dump_bytes("set new password data: ", DUMP_PREFIX_NONE, buffer, buffer_size);

	ret = call_password_interface(wmi_priv.password_attr_wdev, buffer, buffer_size);

	/* on success copy the new password to current password */

	if (!ret)