Commit d1a8b2c3 authored by Tariq Toukan's avatar Tariq Toukan Committed by Saeed Mahameed
Browse files

net/mlx5e: Block TLS device offload on combined SD netdev 



1) Each TX TLS device offloaded context has its own TIS object.  Extra work
is needed to get it working in a SD environment, where a stream can move
between different SQs (belonging to different mdevs).

2) Each RX TLS device offloaded context needs a DEK object from the DEK
pool.

Extra work is needed to get it working in a SD environment, as the DEK
pool currently falsely depends on TX cap, and is on the primary device
only.

Disallow this combination for now.

Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarGal Pressman <gal@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 7f525acb

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c

+1 −1
Original line number Diff line number Diff line
@@ -96,7 +96,7 @@ bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev) 
{

	u8 max_sq_wqebbs = mlx5e_get_max_sq_wqebbs(mdev);



	if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx))

	if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx) || mlx5_get_sd(mdev))

		return false;



	/* Check the possibility to post the required ICOSQ WQEs. */

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h

+3 −1
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ 


#ifdef CONFIG_MLX5_EN_TLS

#include "lib/crypto.h"

#include "lib/mlx5.h"



struct mlx5_crypto_dek *mlx5_ktls_create_key(struct mlx5_crypto_dek_pool *dek_pool,

					     struct tls_crypto_info *crypto_info);
@@ -61,7 +62,8 @@ void mlx5e_ktls_rx_resync_destroy_resp_list(struct mlx5e_ktls_resync_resp *resp_ 


static inline bool mlx5e_is_ktls_tx(struct mlx5_core_dev *mdev)

{

	return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx);

	return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx) &&

		!mlx5_get_sd(mdev);

}



bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev);