Commit d1ca8698 authored by Al Viro's avatar Al Viro
Browse files

spufs: fix a leak on spufs_new_file() failure 



It's called from spufs_fill_dir(), and caller of that will do
spufs_rmdir() in case of failure.  That does remove everything
we'd managed to create, but... the problem dentry is still
negative.  IOW, it needs to be explicitly dropped.

Fixes: 3f51dd91 "[PATCH] spufs: fix spufs_fill_dir error path"
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 80e54e84

arch/powerpc/platforms/cell/spufs/inode.c

+3 −1
Original line number Diff line number Diff line
@@ -192,8 +192,10 @@ static int spufs_fill_dir(struct dentry *dir, 
			return -ENOMEM;

		ret = spufs_new_file(dir->d_sb, dentry, files->ops,

					files->mode & mode, files->size, ctx);

		if (ret)

		if (ret) {

			dput(dentry);

			return ret;

		}

		files++;

	}

	return 0;