Commit d1d32057 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Lee Jones
Browse files

leds: tca6507: Use new GPIO line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20250423-gpiochip-set-rv-leds-v1-4-2f42d8fbb525@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent e1cc2c8c

drivers/leds/leds-tca6507.c

+6 −5
Original line number Diff line number Diff line
@@ -588,8 +588,8 @@ static int tca6507_blink_set(struct led_classdev *led_cdev, 
}



#ifdef CONFIG_GPIOLIB

static void tca6507_gpio_set_value(struct gpio_chip *gc,

				   unsigned offset, int val)

static int tca6507_gpio_set_value(struct gpio_chip *gc, unsigned int offset,

				  int val)

{

	struct tca6507_chip *tca = gpiochip_get_data(gc);

	unsigned long flags;
@@ -604,13 +604,14 @@ static void tca6507_gpio_set_value(struct gpio_chip *gc, 
	spin_unlock_irqrestore(&tca->lock, flags);

	if (tca->reg_set)

		schedule_work(&tca->work);



	return 0;

}



static int tca6507_gpio_direction_output(struct gpio_chip *gc,

					  unsigned offset, int val)

{

	tca6507_gpio_set_value(gc, offset, val);

	return 0;

	return tca6507_gpio_set_value(gc, offset, val);

}



static int tca6507_probe_gpios(struct device *dev,
@@ -636,7 +637,7 @@ static int tca6507_probe_gpios(struct device *dev, 
	tca->gpio.base = -1;

	tca->gpio.owner = THIS_MODULE;

	tca->gpio.direction_output = tca6507_gpio_direction_output;

	tca->gpio.set = tca6507_gpio_set_value;

	tca->gpio.set_rv = tca6507_gpio_set_value;

	tca->gpio.parent = dev;

	err = devm_gpiochip_add_data(dev, &tca->gpio, tca);

	if (err) {