Commit d1e27ee9 authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)
Browse files

tracing: Return -EINVAL if a boot tracer tries to enable the mmiotracer at boot 

The mmiotracer is not set to be enabled at boot up from the kernel command
line. If the boot command line tries to enable that tracer, it will fail
to be enabled. The return code is currently zero when that happens so the
caller just thinks it was enabled. Return -EINVAL in this case.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/20241219201344.854254394@goodmis.org


Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent d33b10c0

kernel/trace/trace.c

+1 −1
Original line number Diff line number Diff line
@@ -6116,7 +6116,7 @@ int tracing_set_tracer(struct trace_array *tr, const char *buf) 
	if (system_state < SYSTEM_RUNNING && t->noboot) {

		pr_warn("Tracer '%s' is not allowed on command line, ignored\n",

			t->name);

		return 0;

		return -EINVAL;

	}



	/* Some tracers are only allowed for the top level buffer */