Commit d21b3c60 authored by Colin Ian King's avatar Colin Ian King Committed by Sean Christopherson
Browse files

KVM: selftests: Fix shift of 32 bit unsigned int more than 32 bits 



Currrentl a 32 bit 1u value is being shifted more than 32 bits causing
overflow and incorrect checking of bits 32-63. Fix this by using the
BIT_ULL macro for shifting bits.

Detected by cppcheck:
sev_init2_tests.c:108:34: error: Shifting 32-bit value by 63 bits is
undefined behaviour [shiftTooManyBits]

Fixes: dfc083a1 ("selftests: kvm: add tests for KVM_SEV_INIT2")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Link: https://lore.kernel.org/r/20240523154102.2236133-1-colin.i.king@gmail.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent c3f38fa6

tools/testing/selftests/kvm/x86_64/sev_init2_tests.c

+2 −2
Original line number Diff line number Diff line
@@ -105,11 +105,11 @@ void test_features(uint32_t vm_type, uint64_t supported_features) 
	int i;



	for (i = 0; i < 64; i++) {

		if (!(supported_features & (1u << i)))

		if (!(supported_features & BIT_ULL(i)))

			test_init2_invalid(vm_type,

				&(struct kvm_sev_init){ .vmsa_features = BIT_ULL(i) },

				"unknown feature");

		else if (KNOWN_FEATURES & (1u << i))

		else if (KNOWN_FEATURES & BIT_ULL(i))

			test_init2(vm_type,

				&(struct kvm_sev_init){ .vmsa_features = BIT_ULL(i) });

	}