Unverified Commit d2324a93 authored by Christian Brauner's avatar Christian Brauner
Browse files

nsfs: tighten permission checks for handle opening 

Even privileged services should not necessarily be able to see other
privileged service's namespaces so they can't leak information to each
other. Use may_see_all_namespaces() helper that centralizes this policy
until the nstree adapts.

Link: https://patch.msgid.link/20260226-work-visibility-fixes-v1-2-d2c2853313bd@kernel.org


Fixes: 5222470b ("nsfs: support file handles")
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Cc: stable@kernel.org # v6.18+
Signed-off-by: default avatarChristian Brauner <brauner@kernel.org>
parent e6b899f0

fs/nsfs.c

+1 −1
Original line number Diff line number Diff line
@@ -627,7 +627,7 @@ static struct dentry *nsfs_fh_to_dentry(struct super_block *sb, struct fid *fh, 
		return ERR_PTR(-EOPNOTSUPP);

	}



	if (owning_ns && !ns_capable(owning_ns, CAP_SYS_ADMIN)) {

	if (owning_ns && !may_see_all_namespaces()) {

		ns->ops->put(ns);

		return ERR_PTR(-EPERM);

	}