Commit d2356495 authored by Aditya Garg's avatar Aditya Garg Committed by Jakub Kicinski
Browse files

net: hv_netvsc: reject RSS hash key programming without RX indirection table 



RSS configuration requires a valid RX indirection table. When the device
reports a single receive queue, rndis_filter_device_add() does not
allocate an indirection table, accepting RSS hash key updates in this
state leads to a hang.

Fix this by gating netvsc_set_rxfh() on ndc->rx_table_sz and return
-EOPNOTSUPP when the table is absent. This aligns set_rxfh with the device
capabilities and prevents incorrect behavior.

Fixes: 962f3fee ("netvsc: add ethtool ops to get/set RSS key")
Signed-off-by: default avatarAditya Garg <gargaditya@linux.microsoft.com>
Reviewed-by: default avatarDipayaan Roy <dipayanroy@linux.microsoft.com>
Reviewed-by: default avatarHaiyang Zhang <haiyangz@microsoft.com>
Link: https://patch.msgid.link/1768212093-1594-1-git-send-email-gargaditya@linux.microsoft.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fa572669

drivers/net/hyperv/netvsc_drv.c

+3 −0
Original line number Diff line number Diff line
@@ -1750,6 +1750,9 @@ static int netvsc_set_rxfh(struct net_device *dev, 
	    rxfh->hfunc != ETH_RSS_HASH_TOP)

		return -EOPNOTSUPP;



	if (!ndc->rx_table_sz)

		return -EOPNOTSUPP;



	rndis_dev = ndev->extension;

	if (rxfh->indir) {

		for (i = 0; i < ndc->rx_table_sz; i++)