Commit d266f63b authored by Manivannan Sadhasivam's avatar Manivannan Sadhasivam Committed by Manivannan Sadhasivam
Browse files

PCI: dwc: Rework the error print of dw_pcie_wait_for_link() 



For the cases where the link cannot come up later i.e., when LTSSM is not
in Detect.{Quiet/Active} or Poll.{Active/Compliance} states,
dw_pcie_wait_for_link() should log an error.

So promote dev_info() to dev_err(), reword the error log to make it clear
and also print the LTSSM state to aid debugging.

Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
Tested-by: default avatarRichard Zhu <hongxing.zhu@nxp.com>
Tested-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Reviewed-by: default avatarShawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Link: https://patch.msgid.link/20260120-pci-dwc-suspend-rework-v4-4-2f32d5082549@oss.qualcomm.com
parent 36dd677f

drivers/pci/controller/dwc/pcie-designware.c

+2 −1
Original line number Diff line number Diff line
@@ -787,7 +787,8 @@ int dw_pcie_wait_for_link(struct dw_pcie *pci) 
			return -EIO;

		}



		dev_info(pci->dev, "Phy link never came up\n");

		dev_err(pci->dev, "Link failed to come up. LTSSM: %s\n",

			dw_pcie_ltssm_status_string(ltssm));

		return -ETIMEDOUT;

	}