Commit d2fe1923 authored by Daniel Wagner's avatar Daniel Wagner Committed by Keith Busch
Browse files

nvme: only allow entering LIVE from CONNECTING state 



The fabric transports and also the PCI transport are not entering the
LIVE state from NEW or RESETTING. This makes the state machine more
restrictive and allows to catch not supported state transitions, e.g.
directly switching from RESETTING to LIVE.

Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Signed-off-by: default avatarDaniel Wagner <wagi@kernel.org>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent f13409bb

drivers/nvme/host/core.c

+0 −2
Original line number Diff line number Diff line
@@ -564,8 +564,6 @@ bool nvme_change_ctrl_state(struct nvme_ctrl *ctrl, 
	switch (new_state) {

	case NVME_CTRL_LIVE:

		switch (old_state) {

		case NVME_CTRL_NEW:

		case NVME_CTRL_RESETTING:

		case NVME_CTRL_CONNECTING:

			changed = true;

			fallthrough;