Commit d3153c3b authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

net: fix the missing unlock for detached devices 



The combined condition was left as is when we converted
from __dev_get_by_index() to netdev_get_by_index_lock().
There was no need to undo anything with the former, for
the latter we need an unlock.

Fixes: 1d22d306 ("net: drop rtnl_lock for queue_mgmt operations")
Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250418015317.1954107-1-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b9a4c74b

net/core/netdev-genl.c

+6 −3
Original line number Diff line number Diff line
@@ -861,14 +861,17 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info) 


	mutex_lock(&priv->lock);



	err = 0;

	netdev = netdev_get_by_index_lock(genl_info_net(info), ifindex);

	if (!netdev || !netif_device_present(netdev)) {

	if (!netdev) {

		err = -ENODEV;

		goto err_unlock_sock;

	}



	if (!netdev_need_ops_lock(netdev)) {

	if (!netif_device_present(netdev))

		err = -ENODEV;

	else if (!netdev_need_ops_lock(netdev))

		err = -EOPNOTSUPP;

	if (err) {

		NL_SET_BAD_ATTR(info->extack,

				info->attrs[NETDEV_A_DEV_IFINDEX]);

		goto err_unlock;