Commit d3314efd authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/tests: hdmi: handle empty modes in find_preferred_mode() 



If the connector->modes list is empty, then list_first_entry() returns a
bogus entry. Change that to use list_first_entry_or_null().

Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241130-hdmi-mode-valid-v5-1-742644ec3b1f@linaro.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent cb2e1c21

drivers/gpu/drm/tests/drm_hdmi_state_helper_test.c

+1 −1
Original line number Diff line number Diff line
@@ -46,7 +46,7 @@ static struct drm_display_mode *find_preferred_mode(struct drm_connector *connec 
	struct drm_display_mode *mode, *preferred;



	mutex_lock(&drm->mode_config.mutex);

	preferred = list_first_entry(&connector->modes, struct drm_display_mode, head);

	preferred = list_first_entry_or_null(&connector->modes, struct drm_display_mode, head);

	list_for_each_entry(mode, &connector->modes, head)

		if (mode->type & DRM_MODE_TYPE_PREFERRED)

			preferred = mode;