Commit d33976be authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

hwspinlock: omap: Discard pm_runtime_put() return value 



Failing driver probe due to pm_runtime_put() returning a negative value
is not particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel
has been configured with CONFIG_PM unset.

Accordingly, update omap_hwspinlock_probe() to simply discard the
return value of pm_runtime_put().

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://patch.msgid.link/883243465.0ifERbkFSE@rafael.j.wysocki
parent 7b8de72b

drivers/hwspinlock/omap_hwspinlock.c

+1 −3
Original line number Diff line number Diff line
@@ -101,9 +101,7 @@ static int omap_hwspinlock_probe(struct platform_device *pdev) 
	 * runtime PM will make sure the clock of this module is

	 * enabled again iff at least one lock is requested

	 */

	ret = pm_runtime_put(&pdev->dev);

	if (ret < 0)

		return ret;

	pm_runtime_put(&pdev->dev);



	/* one of the four lsb's must be set, and nothing else */

	if (hweight_long(i & 0xf) != 1 || i > 8)