Commit d362f446 authored by Jiawen Wu's avatar Jiawen Wu Committed by Jakub Kicinski
Browse files

net: libwx: remove unused rx_buffer_pgcnt 



The variable rx_buffer_pgcnt is redundant, just remove it.

Signed-off-by: default avatarJiawen Wu <jiawenwu@trustnetic.com>
Link: https://patch.msgid.link/F0907C8394B2D4A8+20260105071158.49929-1-jiawenwu@trustnetic.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c86af46b

drivers/net/ethernet/wangxun/libwx/wx_lib.c

+4 −13
Original line number Diff line number Diff line
@@ -179,8 +179,7 @@ static void wx_dma_sync_frag(struct wx_ring *rx_ring, 


static struct wx_rx_buffer *wx_get_rx_buffer(struct wx_ring *rx_ring,

					     union wx_rx_desc *rx_desc,

					     struct sk_buff **skb,

					     int *rx_buffer_pgcnt)

					     struct sk_buff **skb)

{

	struct wx_rx_buffer *rx_buffer;

	unsigned int size;
@@ -188,12 +187,6 @@ static struct wx_rx_buffer *wx_get_rx_buffer(struct wx_ring *rx_ring, 
	rx_buffer = &rx_ring->rx_buffer_info[rx_ring->next_to_clean];

	size = le16_to_cpu(rx_desc->wb.upper.length);



#if (PAGE_SIZE < 8192)

	*rx_buffer_pgcnt = page_count(rx_buffer->page);

#else

	*rx_buffer_pgcnt = 0;

#endif



	prefetchw(rx_buffer->page);

	*skb = rx_buffer->skb;
@@ -221,8 +214,7 @@ static struct wx_rx_buffer *wx_get_rx_buffer(struct wx_ring *rx_ring, 


static void wx_put_rx_buffer(struct wx_ring *rx_ring,

			     struct wx_rx_buffer *rx_buffer,

			     struct sk_buff *skb,

			     int rx_buffer_pgcnt)

			     struct sk_buff *skb)

{

	/* clear contents of rx_buffer */

	rx_buffer->page = NULL;
@@ -685,7 +677,6 @@ static int wx_clean_rx_irq(struct wx_q_vector *q_vector, 
		struct wx_rx_buffer *rx_buffer;

		union wx_rx_desc *rx_desc;

		struct sk_buff *skb;

		int rx_buffer_pgcnt;



		/* return some buffers to hardware, one at a time is too slow */

		if (cleaned_count >= WX_RX_BUFFER_WRITE) {
@@ -703,7 +694,7 @@ static int wx_clean_rx_irq(struct wx_q_vector *q_vector, 
		 */

		dma_rmb();



		rx_buffer = wx_get_rx_buffer(rx_ring, rx_desc, &skb, &rx_buffer_pgcnt);

		rx_buffer = wx_get_rx_buffer(rx_ring, rx_desc, &skb);



		/* retrieve a buffer from the ring */

		skb = wx_build_skb(rx_ring, rx_buffer, rx_desc);
@@ -714,7 +705,7 @@ static int wx_clean_rx_irq(struct wx_q_vector *q_vector, 
			break;

		}



		wx_put_rx_buffer(rx_ring, rx_buffer, skb, rx_buffer_pgcnt);

		wx_put_rx_buffer(rx_ring, rx_buffer, skb);

		cleaned_count++;



		/* place incomplete frames back on ring for completion */