Commit d3726ab4 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

selftests: drv-net: probe for AF_XDP sockets more explicitly 



Separate the support check from socket binding for easier refactoring.
Use: ./helper - - just to probe if we can open the socket.

Acked-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Tested-by: default avatarJoe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/20250219234956.520599-5-kuba@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent bab59dcf

tools/testing/selftests/drivers/net/queues.py

+7 −5
Original line number Diff line number Diff line
@@ -25,6 +25,13 @@ def nl_get_queues(cfg, nl, qtype='rx'): 
    return None



def check_xdp(cfg, nl, xdp_queue_id=0) -> None:

    # Probe for support

    xdp = cmd(cfg.rpath("xdp_helper") + ' - -', fail=False)

    if xdp.ret == 255:

        raise KsftSkipEx('AF_XDP unsupported')

    elif xdp.ret > 0:

        raise KsftFailEx('unable to create AF_XDP socket')



    xdp = subprocess.Popen([cfg.rpath("xdp_helper"), f"{cfg.ifindex}", f"{xdp_queue_id}"],

                           stdin=subprocess.PIPE, stdout=subprocess.PIPE, bufsize=1,

                           text=True)
@@ -33,11 +40,6 @@ def check_xdp(cfg, nl, xdp_queue_id=0) -> None: 
    stdout, stderr = xdp.communicate(timeout=10)

    rx = tx = False



    if xdp.returncode == 255:

        raise KsftSkipEx('AF_XDP unsupported')

    elif xdp.returncode > 0:

        raise KsftFailEx('unable to create AF_XDP socket')



    queues = nl.queue_get({'ifindex': cfg.ifindex}, dump=True)

    if not queues:

        raise KsftSkipEx("Netlink reports no queues")

tools/testing/selftests/drivers/net/xdp_helper.c

+7 −0
Original line number Diff line number Diff line
@@ -50,6 +50,13 @@ int main(int argc, char **argv) 
		return 1;

	}



	/* "Probing mode", just checking if AF_XDP sockets are supported */

	if (!strcmp(argv[1], "-") && !strcmp(argv[2], "-")) {

		printf("AF_XDP support detected\n");

		close(sock_fd);

		return 0;

	}



	ifindex = atoi(argv[1]);

	queue = atoi(argv[2]);