Commit d37307ea authored by Zhengchao Shao's avatar Zhengchao Shao Committed by David S. Miller
Browse files

net/smc: remove redundant code in smc_connect_check_aclc 



When the SMC client perform CLC handshake, it will check whether
the clc header type is correct in receiving SMC_CLC_ACCEPT packet.
The specific invoking path is as follows:
__smc_connect
  smc_connect_clc
    smc_clc_wait_msg
      smc_clc_msg_hdr_valid
        smc_clc_msg_acc_conf_valid
Therefore, the smc_connect_check_aclc interface invoked by
__smc_connect does not need to check type again.

Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 5a795757

net/smc/af_smc.c

+0 −4
Original line number Diff line number Diff line
@@ -1466,10 +1466,6 @@ static int smc_connect_ism(struct smc_sock *smc, 
static int smc_connect_check_aclc(struct smc_init_info *ini,

				  struct smc_clc_msg_accept_confirm *aclc)

{

	if (aclc->hdr.typev1 != SMC_TYPE_R &&

	    aclc->hdr.typev1 != SMC_TYPE_D)

		return SMC_CLC_DECL_MODEUNSUPP;



	if (aclc->hdr.version >= SMC_V2) {

		if ((aclc->hdr.typev1 == SMC_TYPE_R &&

		     !smcr_indicated(ini->smc_type_v2)) ||