Commit d395d0a5 authored by Alexander Mikhalitsyn's avatar Alexander Mikhalitsyn Committed by Miklos Szeredi
Browse files

fuse: support idmapped ->set_acl 



It's just a matter of adjusting a permission check condition
for S_ISGID flag. All the rest is already handled in the generic
VFS code.

Notice that this permission check is the analog of what
we have in posix_acl_update_mode() generic helper, but
fuse doesn't use this helper as on the kernel side we don't
care about ensuring that POSIX ACL and CHMOD permissions are in sync
as it is a responsibility of a userspace daemon to handle that.
For the same reason we don't have a calls to posix_acl_chmod(),
while most of other filesystem do.

Signed-off-by: default avatarAlexander Mikhalitsyn <aleksandr.mikhalitsyn@canonical.com>
Reviewed-by: default avatarChristian Brauner <brauner@kernel.org>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
parent 4d833bef

fs/fuse/acl.c

+2 −2
Original line number Diff line number Diff line
@@ -144,8 +144,8 @@ int fuse_set_acl(struct mnt_idmap *idmap, struct dentry *dentry, 
		 * be stripped.

		 */

		if (fc->posix_acl &&

		    !in_group_or_capable(&nop_mnt_idmap, inode,

					 i_gid_into_vfsgid(&nop_mnt_idmap, inode)))

		    !in_group_or_capable(idmap, inode,

					 i_gid_into_vfsgid(idmap, inode)))

			extra_flags |= FUSE_SETXATTR_ACL_KILL_SGID;



		ret = fuse_setxattr(inode, name, value, size, 0, extra_flags);