Commit d3ac65d2 authored by Leo Stone's avatar Leo Stone Committed by Andrew Morton
Browse files

mm: huge_memory: handle strsep not finding delimiter 

split_huge_pages_write() does not handle the case where strsep finds no
delimiter in the given string and sets the input buffer to NULL, which
allows this reproducer to trigger a protection fault.

Link: https://lkml.kernel.org/r/20241216042752.257090-2-leocstone@gmail.com


Signed-off-by: default avatarLeo Stone <leocstone@gmail.com>
Reported-by: default avatar <syzbot+8a3da2f1bbf59227c289@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=8a3da2f1bbf59227c289


Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 60da7445

mm/huge_memory.c

+1 −1
Original line number Diff line number Diff line
@@ -4169,7 +4169,7 @@ static ssize_t split_huge_pages_write(struct file *file, const char __user *buf, 
		size_t input_len = strlen(input_buf);



		tok = strsep(&buf, ",");

		if (tok) {

		if (tok && buf) {

			strscpy(file_path, tok);

		} else {

			ret = -EINVAL;