Commit d3ae5f46 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

net: rps: move received_rps field to a better location 



Commit 14d898f3 ("dev: Move received_rps counter next
to RPS members in softnet data") was unfortunate:

received_rps is dirtied by a cpu and never read by other
cpus in fast path.

Its presence in the hot RPS cache line (shared by many cpus)
is hurting RPS/RFS performance.

Signed-off-by: default avatarEric Dumazet <edumazet@google.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent c62fdf5b

include/linux/netdevice.h

+1 −1
Original line number Diff line number Diff line
@@ -3204,6 +3204,7 @@ struct softnet_data { 
	struct softnet_data	*rps_ipi_list;

#endif



	unsigned int		received_rps;

	bool			in_net_rx_action;

	bool			in_napi_threaded_poll;
@@ -3236,7 +3237,6 @@ struct softnet_data { 
	unsigned int		cpu;

	unsigned int		input_queue_tail;

#endif

	unsigned int		received_rps;

	struct sk_buff_head	input_pkt_queue;

	struct napi_struct	backlog;