Commit d3ca35c6 authored by Stanislav Fomichev's avatar Stanislav Fomichev Committed by Jakub Kicinski
Browse files

selftests: ncdevmem: Remove default arguments 



To make it clear what's required and what's not. Also, some of the
values don't seem like a good defaults; for example eth1.

Move the invocation comment to the top, add missing -s to the client
and cleanup the client invocation a bit to make more readable.

Reviewed-by: default avatarMina Almasry <almasrymina@google.com>
Reviewed-by: default avatarJoe Damato <jdamato@fastly.com>
Signed-off-by: default avatarStanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20241107181211.3934153-6-sdf@fomichev.me


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 0ebd75f5

tools/testing/selftests/net/ncdevmem.c

+39 −22
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0

/*

 * tcpdevmem netcat. Works similarly to netcat but does device memory TCP

 * instead of regular TCP. Uses udmabuf to mock a dmabuf provider.

 *

 * Usage:

 *

 *     On server:

 *     ncdevmem -s <server IP> [-c <client IP>] -f eth1 -l -p 5201

 *

 *     On client:

 *     echo -n "hello\nworld" | nc -s <server IP> 5201 -p 5201

 *

 * Test data validation:

 *

 *     On server:

 *     ncdevmem -s <server IP> [-c <client IP>] -f eth1 -l -p 5201 -v 7

 *

 *     On client:

 *     yes $(echo -e \\x01\\x02\\x03\\x04\\x05\\x06) | \

 *             tr \\n \\0 | \

 *             head -c 5G | \

 *             nc <server IP> 5201 -p 5201

 *

 *

 * Note this is compatible with regular netcat. i.e. the sender or receiver can

 * be replaced with regular netcat to test the RX or TX path in isolation.

 */

#define _GNU_SOURCE

#define __EXPORTED_HEADERS__
@@ -42,32 +69,13 @@ 
#define MSG_SOCK_DEVMEM 0x2000000

#endif



/*

 * tcpdevmem netcat. Works similarly to netcat but does device memory TCP

 * instead of regular TCP. Uses udmabuf to mock a dmabuf provider.

 *

 * Usage:

 *

 *	On server:

 *	ncdevmem -s <server IP> -c <client IP> -f eth1 -l -p 5201 -v 7

 *

 *	On client:

 *	yes $(echo -e \\x01\\x02\\x03\\x04\\x05\\x06) | \

 *		tr \\n \\0 | \

 *		head -c 5G | \

 *		nc <server IP> 5201 -p 5201

 *

 * Note this is compatible with regular netcat. i.e. the sender or receiver can

 * be replaced with regular netcat to test the RX or TX path in isolation.

 */



static char *server_ip = "192.168.1.4";

static char *server_ip;

static char *client_ip;

static char *port = "5201";

static char *port;

static size_t do_validation;

static int start_queue = 8;

static int num_queues = 8;

static char *ifname = "eth1";

static char *ifname;

static unsigned int ifindex;

static unsigned int dmabuf_id;
@@ -595,6 +603,15 @@ int main(int argc, char *argv[]) 
		}

	}



	if (!server_ip)

		error(1, 0, "Missing -s argument\n");



	if (!port)

		error(1, 0, "Missing -p argument\n");



	if (!ifname)

		error(1, 0, "Missing -f argument\n");



	ifindex = if_nametoindex(ifname);



	for (; optind < argc; optind++)